Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symfony 7 #84

Closed
wants to merge 4 commits into from
Closed

Allow symfony 7 #84

wants to merge 4 commits into from

Conversation

ehymel
Copy link

@ehymel ehymel commented Jan 8, 2024

No description provided.

Copy link
Member

@garak garak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the next time, it's a good habit to mention the issue solved by your PR.

About your proposed changes, let's remove support for Symfony 4. Supporting three versions of the framework is enough.

@ehymel
Copy link
Author

ehymel commented Jan 13, 2024

Done for issue #83

Copy link
Member

@garak garak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need to remove the old versions of PHP/Symfony from the CI and to add the new ones.

@ehymel
Copy link
Author

ehymel commented Jan 14, 2024

build.yaml updated to remove symfony 4.4 and add symfony 7

@ehymel
Copy link
Author

ehymel commented Jan 14, 2024

The check fails due to lexik/form-filter-bundle not allowing php 8.2 (which is required for symfony 7).

It seems that lexik/form-filter-bundle is abandoned with recommendation for a replacement, but I don't use the functionality that lexik/form-filter-bundle provides, so I have no interest in pursuing the replacement. Not sure how you'd like to handle.

@ehymel
Copy link
Author

ehymel commented Jan 14, 2024

It seems lexik/form-filter-bundle has a version 8 that doesn't choke on php 8, but now fails because of the symfony version requirements of this abandoned package.

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 17, 2024
@BazylPL
Copy link

BazylPL commented Apr 26, 2024

anything?

@stale stale bot removed the wontfix label Apr 26, 2024
@garak
Copy link
Member

garak commented Jul 22, 2024

Closing in favour of #91

@garak garak closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants