-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow symfony 7 #84
Allow symfony 7 #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the next time, it's a good habit to mention the issue solved by your PR.
About your proposed changes, let's remove support for Symfony 4. Supporting three versions of the framework is enough.
Done for issue #83 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still need to remove the old versions of PHP/Symfony from the CI and to add the new ones.
build.yaml updated to remove symfony 4.4 and add symfony 7 |
The check fails due to lexik/form-filter-bundle not allowing php 8.2 (which is required for symfony 7). It seems that lexik/form-filter-bundle is abandoned with recommendation for a replacement, but I don't use the functionality that lexik/form-filter-bundle provides, so I have no interest in pursuing the replacement. Not sure how you'd like to handle. |
It seems lexik/form-filter-bundle has a version 8 that doesn't choke on php 8, but now fails because of the symfony version requirements of this abandoned package. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
anything? |
Closing in favour of #91 |
No description provided.