Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-user: provide example #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jourdain
Copy link

No description provided.

@jourdain
Copy link
Author

@SergeyYakubov

@gecage952
Copy link

Nice! This works well for me. The only comment I have is that it seems to run at localhost:8080 instead of localhost:8080/app even after setting EP_PATH.

@jourdain
Copy link
Author

Indeed but I though those path will be managed outside of the container in a gateway or something.

Why do you need to have a specific path within that docker image? Also does that need to be a runtime or build time option for within docker handling?

@gecage952
Copy link

@SergeyYakubov could correct me if I'm wrong, but because we're integrating these apps as tools into Galaxy (workflow management platform we're using) these apps get assigned paths dynamically. Like a user could potentially click and launch the tool (or multiple), and then Galaxy will start the app, assign it a path (partially using EP_PATH, etc. The ngnix config in the repo kinda illustrates what I'm talking about.

@jourdain
Copy link
Author

I get the dynamic part which means it is really at runtime and not build time.
But I guess my next question, does the service needs to maintain internally the path assigned on the fly by galaxy or the dynamic infrastructure of galaxy allow to rewrite URL and map them to the root of a running service?

@gecage952
Copy link

Ah, I get what you're saying.Yeah, it's probably not an issue, as I believe we actually can just do this via Galaxy. I'm fine with merging this if @SergeyYakubov also approves.

@jourdain
Copy link
Author

I'm currently working on enabling that base path in our docker image. So worst case scenario, you will have that available if need be.

@SergeyYakubov
Copy link
Contributor

It depends on the app and how it is implemented. Galaxy can redirect calvera.ornl.gov/app/xxx/ to somehost/xxx. But if the app is unaware of /app and wants to route to /yyy instead of /app/yyy, we'll have a problem. Which might not be the case with Trame, I'm not sure here.

@jourdain
Copy link
Author

The app is aware internally and, therefore, can adjust any URL call if need be.

@gecage952
Copy link

So, I tried integrating your branch with this repository's dev branch, and I was running into issues getting it working. Since the dev branch is where all of the actual development is happening, can you create an mr to that branch instead and see if it works there (from docker)?

@jourdain
Copy link
Author

jourdain commented Jul 3, 2024

Ok I'll start a new branch from dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants