Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Cleanup ExpressionNode.php #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

TASK: Cleanup ExpressionNode.php #32

wants to merge 1 commit into from

Conversation

mhsdesign
Copy link
Contributor

The additions that here from #18 are not necessary. The condition is also handled by the "while" loop and later comes the return.

I think i messed stuff up because the partial fix belongs to #10

either way, it works as it is, just not super clean, thats why i removed the duplicate logic.

@mhsdesign
TASK: Cleanup ExpressionNode.php
62d7da3 
The additions that here from #18 are not necessary. The condition is also handled by the "while" loop and later comes the return. 

I think i messed stuff up because the partial fix belongs to #10

either way, it works as it is, just not super clean, thats why i removed the duplicate logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mhsdesign