apt: Fix matching gstreamer pkgs where the only modifier is ()(64bit) #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the list of GstCaps specified is empty, and the only modifier we're given is ()(64bit), our regex eats the outer parenthesis so we're left with ")(64bit" while trying to match "()(64bit". This change would introduce a trailing comma when the list of specified GstCaps is instead not empty, which gst_caps_from_string today can handle, but for abundance of caution let's avoid it. Test cases: pkcon what-provides "gstreamer1(decoder-audio/mpeg)(mpegversion=4)()(64bit)" pkcon what-provides "gstreamer1(decoder-audio/mpeg)(mpegversion=4)" pkcon what-provides "gstreamer1(decoder-video/x-h265)()(64bit)" pkcon what-provides "gstreamer1(decoder-video/x-h265)"
|
Looks good to me. Code seems a bit fragile though (not as per your change), so wondering if we can add some testing to ensure we're not breaking anything now or in the future. |
|
Added tests |
3v1n0
reviewed
Nov 27, 2024
3v1n0
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the list of GstCaps specified is empty, and the only modifier we're given is ()(64bit), our regex eats the outer parenthesis so we're left with ")(64bit" while trying to match "()(64bit".
This change would introduce a trailing comma when the list of specified GstCaps is instead not empty, which gst_caps_from_string today can handle, but for abundance of caution let's avoid it.
Test cases: