Update to the latest version of httpin including omitempty #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecsammon
commented
May 20, 2024
go.mod
Outdated
| @@ -3,7 +3,7 @@ module github.com/PaddleHQ/paddle-go-sdk | |||
| go 1.21.0 | |||
|
|
|||
| require ( | |||
| github.com/ggicci/httpin v0.18.1 | |||
| github.com/ggicci/httpin v0.18.2-0.20240520043217-eed0621e7f51 | |||
There was a problem hiding this comment.
we don't currently have a tagged version available.
I am hoping this will be added soon - and will update the PR once this is ready.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
httpin now has native support for
omitempty. ggicci/httpin#107This means we can remove the custom directive we have included.
The syntax is a little different - uses
;omitemptyinstead of,omitempty. As such the auto generated files will need to be changed.