Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support for proration on subscription transaction detail line items #42

Merged
merged 2 commits into from
Sep 25, 2024
Merged

fix: Support for proration on subscription transaction detail line items #42

merged 2 commits into from
Sep 25, 2024

Conversation

davidgrayston-paddle
Copy link
Contributor

Added

  • Support for proration on subscription recurring_transaction_details.line_items[] and next_transaction.details.line_items[]

Changed

  • TimePeriod is now aligned to API specification:
    • Existing shared TimePeriod was renamed to Duration (with properties interval and frequency)
    • New shared TimePeriod was added (with properties starts_at and ends_at)
  • Replaced AdjustmentTimePeriod, SubscriptionTimePeriod and TransactionTimePeriod with shared TimePeriod
  • Replaced AdjustmentProration, SubscriptionProration and TransactionProration with shared Proration

@davidgrayston-paddle davidgrayston-paddle self-assigned this Sep 25, 2024
@davidgrayston-paddle davidgrayston-paddle requested a review from a team as a code owner September 25, 2024 13:56
vifer
vifer previously approved these changes Sep 25, 2024
View reviewed changes
@davidgrayston-paddle davidgrayston-paddle force-pushed the feat/subscription-transaction-proration branch from 798b48c to 17e4822 Compare September 25, 2024 15:43
@davidgrayston-paddle davidgrayston-paddle merged commit fe0b79f into main Sep 25, 2024
5 checks passed
@davidgrayston-paddle davidgrayston-paddle deleted the feat/subscription-transaction-proration branch September 25, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vifer vifer vifer approved these changes

@mikeymike mikeymike Awaiting requested review from mikeymike

Assignees

@davidgrayston-paddle davidgrayston-paddle

Labels
norelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidgrayston-paddle @vifer