Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Return UndefinedEntity for unknown notification entity types #55

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix: Return UndefinedEntity for unknown notification entity types #55

merged 1 commit into from
Oct 7, 2024

Conversation

davidgrayston-paddle
Copy link
Contributor

Fixed

  • Return paddle_billing.Notifications.Entities.UndefinedEntity for unknown notification entity types.
    • paddle_billing.Notifications.Entities.Entity and paddle_billing.Notifications.Entities.UndefinedEntity implement common EntityDict protocol.

@davidgrayston-paddle davidgrayston-paddle self-assigned this Oct 7, 2024
@davidgrayston-paddle davidgrayston-paddle requested a review from a team as a code owner October 7, 2024 12:38
vifer
vifer approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@vifer vifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖌️

@davidgrayston-paddle davidgrayston-paddle merged commit 40a5008 into main Oct 7, 2024
7 checks passed
@davidgrayston-paddle davidgrayston-paddle deleted the fix/notification-entity branch October 7, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeymike mikeymike mikeymike approved these changes

@vifer vifer vifer approved these changes

Assignees

@davidgrayston-paddle davidgrayston-paddle

Labels
norelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidgrayston-paddle @mikeymike @vifer