Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Subscription notification should always return billing period when set #75

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix: Subscription notification should always return billing period when set #75

merged 1 commit into from
Nov 20, 2024

Conversation

davidgrayston-paddle
Copy link
Contributor

Fixed

  • paddle_billing.Notifications.Entities.Subscription and paddle_billing.Notifications.Entities.SubscriptionCreated current_billing_period would return None if billing_details was None. current_billing_period will now return TimePeriod when set.

@davidgrayston-paddle davidgrayston-paddle self-assigned this Nov 20, 2024
@davidgrayston-paddle davidgrayston-paddle requested a review from a team as a code owner November 20, 2024 15:08
@davidgrayston-paddle davidgrayston-paddle merged commit d1341ee into main Nov 20, 2024
7 checks passed
@davidgrayston-paddle davidgrayston-paddle deleted the fix/subscription-notification-billing-period branch November 20, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vifer vifer vifer approved these changes

@mikeymike mikeymike mikeymike approved these changes

Assignees

@davidgrayston-paddle davidgrayston-paddle

Labels
release:patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidgrayston-paddle @mikeymike @vifer