Add param valid log #4113
Merged
Add param valid log #4113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Jiang-Jia-Jun
requested changes
Sep 16, 2025
| del current_req_dict | ||
| except ParameterError as e: | ||
| api_server_logger.error(e.message) | ||
| api_server_logger.error(f"OpenAIServingCompletion format error: {e}, {e.message}") |
There was a problem hiding this comment.
上面也打了一行，有点冗余，可以删除上面那行
xiaolei373
force-pushed
the
add_param_valid_log
branch
from
56326d9 to
0761dab
Compare
xiaolei373
force-pushed
the
add_param_valid_log
branch
from
0761dab to
95a016b
Compare
Jiang-Jia-Jun
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在统一全局错误格式时，输入的超参数校验逻辑前置了但是没有加日志，不便于错误收集。
本次改动点：请求参数校验失败时加上日志输出
单测异常已修复：#4171