complex No.15 sqrt op #57661
complex No.15 sqrt op #57661
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
yangguohao
force-pushed
the
complex_sqrt
branch
2 times, most recently
from
40f272f
to
49be9db
Compare
|
@luotao1 CI-Coverage 能不能帮我 rerun 一下 |
luotao1
added
HappyOpenSource
是覆盖率不够 |
这里的覆盖率是指代码没有运行到这个部分吗？这个应该如何解决 |
|
|
||
| class TestSqrtComplex128(TestSqrt): | ||
| def init_dtype(self): | ||
| self.dtype = np.complex128 |
There was a problem hiding this comment.
看下这两个单测是否跑进去了，如果跑进去的话，贴一个截图上来
yangguohao
force-pushed
the
complex_sqrt
branch
from
d0f97f5
to
49be9db
Compare
yangguohao
force-pushed
the
complex_sqrt
branch
from
49be9db
to
07d7182
Compare
|
Sorry to inform you that 07d7182's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
|
Sorry to inform you that 53fbc3d's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
yangguohao
force-pushed
the
complex_sqrt
branch
from
54fde6d
to
2e9afec
Compare
@luotao1 |
| @@ -1732,7 +1732,9 @@ def _dfs_grad_op(op_desc, fwd_op_desc=None): | |||
| has_infer_inplace = base.core.has_infer_inplace(op_desc.type()) | |||
| has_grad_op_maker = base.core.has_grad_op_maker(op_desc.type()) | |||
| has_infer_inplace_in_grad_descendants = False | |||
| if not has_grad_op_maker: | |||
| # the OP test doesn't support higher order grad | |||
| is_grad_op_desc = op_desc.type().endswith('_grad') | |||
There was a problem hiding this comment.
因为 OpTest 里应该是没有高阶导的测试，而这里的判断就避免 dfs 函数搜到高阶 grad op_desc。
|
Sorry to inform you that 2e9afec's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
|
Sorry to inform you that 236fdba's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
PR types
Others
PR changes
OPs
Description
complex support for sqrt op
#56145