Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

[Dispatcher] Support more ListVariable operations #255

Merged
merged 10 commits into from
Jul 11, 2023
Merged

[Dispatcher] Support more ListVariable operations #255

merged 10 commits into from
Jul 11, 2023

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Jul 7, 2023 •
edited
Loading

支持更多的ListVariable方法

  • append
  • clear
  • copy
  • count
  • extend
  • index
  • insert
  • pop
  • remove
  • reverse
  • sort 单测中列举了一些目前还不支持的操作, 后续可能考虑回滚到动态图执行

相关链接:

@paddle-bot
Copy link

paddle-bot bot commented Jul 7, 2023

Thanks for your contribution!

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jul 7, 2023
@gouzil gouzil requested a review from SigureMo July 8, 2023 03:20
@SigureMo SigureMo changed the title [Dispatcher] Support more ListVariable operate [Dispatcher] Support more ListVariable operations Jul 8, 2023
SigureMo
SigureMo approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NotHaozi
NotHaozi approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@NotHaozi NotHaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SigureMo SigureMo merged commit eb3060e into PaddlePaddle:develop Jul 11, 2023
7 checks passed
@SigureMo SigureMo deleted the list_perfect branch July 11, 2023 09:43
@SigureMo SigureMo mentioned this pull request Jul 11, 2023
Closed
@SigureMo SigureMo added 🐾 meow 快乐喵喵开源活动专属认证 and removed 🐾 meow 快乐喵喵开源活动专属认证 labels Jul 11, 2023
@SigureMo SigureMo mentioned this pull request Aug 2, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SigureMo SigureMo SigureMo approved these changes

@NotHaozi NotHaozi NotHaozi approved these changes

Assignees
No one assigned
Labels
contributor External developers status: proposed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gouzil @SigureMo @NotHaozi