This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[SideEffect] add side effects support for ObjectVariable #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SigureMo
reviewed
Sep 21, 2023
| raise BreakGraphError( | ||
| f"STORE_ATTR don't support {type(obj)}.{key}={val}" | ||
| ) | ||
| obj.setattr(key, val) |
There was a problem hiding this comment.
直接用 BuiltinVariable dispatch 一下就行了，就没有 if-else 了
Comment on lines
187
to
195
| class CustomObject: | ||
| def __init__(self): | ||
| self.x = 0 | ||
|
|
||
| def attr_set(cus_obj): | ||
| cus_obj.x = 2 | ||
|
|
||
| cus_obj = CustomObject() | ||
| attr_set(cus_obj) |
There was a problem hiding this comment.
和其他示例一样，只写生成代码
obj.attr = new_value
Comment on lines
214
to
223
| """ | ||
| class CustomObject: | ||
| def __init__(self): | ||
| self.x = 0 | ||
|
|
||
| def attr_set(cus_obj): | ||
| del cus_obj.x | ||
|
|
||
| cus_obj = CustomObject() | ||
| attr_set(cus_obj) |
| @@ -414,6 +414,7 @@ def __init__( | |||
| self, layer: paddle.nn.Layer, graph: FunctionGraph, tracker: Tracker | |||
| ): | |||
| super().__init__(layer, graph, tracker) | |||
| self.proxy = self.attr_proxy | |||
There was a problem hiding this comment.
这是为什么？proxy 和 attr_proxy 不是一种东西
| """object side effect.""" | ||
| t = t + 1 | ||
| cus_obj.x = t | ||
| return t, cus_obj | ||
| return t, cus_obj.x |
| getattr(cus_obj1, key, "Key does not exist"), | ||
| getattr(cus_obj2, key, "Key does not exist"), | ||
| ) | ||
| self.assert_nest_match(sym_output, paddle_output) |
There was a problem hiding this comment.
同样最好加一个机制，在跑动态图和 SOT 前都先 store 一个 attr，然后跑完就恢复
There was a problem hiding this comment.
有 demo 嘛，目前是只验证传入的那个修改的 key 的值
…o objvariable_side_effects # Conflicts: # sot/opcode_translator/executor/variable_dispatch.py
zrr1999
approved these changes
Sep 26, 2023
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
为什么需要支持
ObjectVariable的 side effects目前还存在的问题:
sot/opcode_translator/executor/side_effects.py中有关Obj的post_gen方法close: #307