Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downstream Tasks Module #275

Merged
merged 138 commits into from
Nov 13, 2023
Merged

Downstream Tasks Module #275

merged 138 commits into from
Nov 13, 2023

Conversation

Pale-Blue-Dot-97
Copy link
Owner

@Pale-Blue-Dot-97 Pale-Blue-Dot-97 commented Oct 14, 2023

Downstream Tasks Module

The culmination of a month of work, this is a major restructuring of minerva that provides greatly enhanced flexibility in defining experiments. This is achieved via the new tasks sub-package that abstracts much of the functionality of Trainer and removes some of the remaining idiosyncrasies of the minerva framework. Also included is a restructuring of logging.

Warning

This PR is a breaking change! Config files will have to be updated for the new functionality!

Major Changes

  • Closes Introduce a Downstream Tasks Module #204
  • Closes Fully Support new paths arg for torchgeo.datasets.RasterDataset #294
  • ✨ NEW: tasks sub-package
  • ✨ NEW: StandardEpoch task to use for a standard training/ testing epoch
  • ✨ NEW: WeightedKNN task to perform KNN validation
  • ✨ NEW: TSNEVis task to perform TSNE clustering
  • ✨ NEW: logging sub-package to hold the renamed tasklog and steplog modules.
  • 🔁 Renamed metrics --> tasklog and logger --> steplog
  • 🔁 Renamed MinervaMetrics --> MinervaTaskLogger and MinervaLogger --> MinervaStepLogger
  • 🔁 Renamed the various loggers to match the new nomenclature
  • 🔰 Incorporated the modelio and the step logger into the task logger
  • 🔣 Various changes to the accepted structure of experiment config files (see example_config.yml)

Warning

🐞Not all functionality has been fully ported to the new structure. Expect bugs! Class balancing and elimination are known bugs.

Warning

🐞 There is an unknown bug in Windows in a single test for trainer. Ignoring this for the time being.

@Pale-Blue-Dot-97 Pale-Blue-Dot-97 merged commit b845919 into beta Nov 13, 2023
5 of 12 checks passed
@Pale-Blue-Dot-97 Pale-Blue-Dot-97 added this to the v0.27 milestone Nov 16, 2023
@Pale-Blue-Dot-97 Pale-Blue-Dot-97 deleted the downstream-tasks-module branch December 2, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request generalise Code needs generalising python Pull requests that update Python code restructure Restructure package testing New tests needed yaml Updates to yaml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant