-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downstream Tasks Module #275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
enhancement
New feature or request
generalise
Code needs generalising
python
Pull requests that update Python code
restructure
Restructure package
testing
New tests needed
yaml
Updates to yaml files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream Tasks Module
The culmination of a month of work, this is a major restructuring of
minerva
that provides greatly enhanced flexibility in defining experiments. This is achieved via the newtasks
sub-package that abstracts much of the functionality ofTrainer
and removes some of the remaining idiosyncrasies of theminerva
framework. Also included is a restructuring of logging.Warning
This PR is a breaking change! Config files will have to be updated for the new functionality!
Major Changes
paths
arg fortorchgeo.datasets.RasterDataset
#294tasks
sub-packageStandardEpoch
task to use for a standard training/ testing epochWeightedKNN
task to perform KNN validationTSNEVis
task to perform TSNE clusteringlogging
sub-package to hold the renamedtasklog
andsteplog
modules.metrics
-->tasklog
andlogger
-->steplog
MinervaMetrics
-->MinervaTaskLogger
andMinervaLogger
-->MinervaStepLogger
modelio
and the step logger into the task loggerexample_config.yml
)Warning
🐞Not all functionality has been fully ported to the new structure. Expect bugs! Class balancing and elimination are known bugs.
Warning
🐞 There is an unknown bug in Windows in a single test for
trainer
. Ignoring this for the time being.