-
-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed color of logout button to red on hover #1201 #1357
changed color of logout button to red on hover #1201 #1357
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
This is the third pull request you have made for this simple issue. Why? The value of your contributions to the repository are only realized when the code is merged. |
Let us know when you are finally finished so we can review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1357 +/- ##
========================================
Coverage 96.99% 96.99%
========================================
Files 137 137
Lines 3426 3426
Branches 963 963
========================================
Hits 3323 3323
Misses 98 98
Partials 5 5 ☔ View full report in Codecov by Sentry. |
this is my second pr as change was requested ,the other pr was raised by someone else .I think this is fine please review it. |
|
@PriyeshPandey2000 this is not the ideal behaviour we wanted a red colour button by default not on hover and the icon and text should have white colour |
will change @aashimawadhwa |
What kind of change does this PR introduce?
bug fix
Issue Number:
#1201
Fixes #
changed css properties
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?