Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of INSTALLATION.md file #3311

Closed

Conversation

SnowFlowerr
Copy link

@SnowFlowerr SnowFlowerr commented Jan 18, 2025

This pull request updates the INSTALLATION.md file to improve readability and fix some errors.

before
Screenshot 2025-01-18 at 6 01 46 PM

After
Screenshot 2025-01-18 at 6 03 03 PM

The formatting Development Setup section in INSTALLATION.md file was incorrect which was affecting its readability.

Checklist

CodeRabbit AI Review

  • I have reviewed and addressed all critical issues flagged by CodeRabbit AI
  • I have implemented or provided justification for each non-critical suggestion
  • I have documented my reasoning in the PR comments where CodeRabbit AI suggestions were not implemented

Test Coverage

  • I have written tests for all new changes/features
  • I have verified that test coverage meets or exceeds 95%
  • I have run the test suite locally and all tests pass

Other information

Increases Readability of INSTALLATION.md

Have you read the contributing guide?

Yes

Summary by CodeRabbit

  • Documentation
    • Enhanced installation guide with comprehensive configuration instructions
    • Added detailed sections for environment setup, configuration, and testing
    • Included steps for running, accessing, registering, and logging into Talawa-Admin
    • Improved clarity of installation process with standardized code formatting

- improve readability of INSTALLATION.md file

Signed-off-by: Bhudeo Krit <[email protected]>
Copy link
Contributor

coderabbitai bot commented Jan 18, 2025

Walkthrough

The pull request enhances the INSTALLATION.md file for the talawa-admin project by introducing comprehensive documentation. The changes include a new Configuration section detailing environment variable setup, a Post Configuration Steps section explaining how to run and access the application, and an expanded Testing section with instructions for running tests, debugging, linting, and using Git hooks. These modifications aim to provide clearer, more detailed installation and setup guidance for developers.

Changes

File Change Summary
INSTALLATION.md - Added Configuration section with .env file setup instructions
- Added environment variable configurations for PORT, REACT_APP_TALAWA_URL, etc.
- Introduced Post Configuration Steps for running and accessing the application
- Expanded Testing section with test running, debugging, and Git hooks instructions

Possibly related PRs

Suggested reviewers

  • palisadoes
  • gautam-divyanshu

Poem

🐰 Hop, hop, config's in sight!
Installation docs now shine so bright
Env vars set with loving care
Testing paths now crystal clear
Talawa-admin, ready to take flight! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Our Pull Request Approval Process

Thanks for contributing!

Testing Your Code

Remember, your PRs won't be reviewed until these criteria are met:

  1. We don't merge PRs with poor code quality.
    1. Follow coding best practices such that CodeRabbit.ai approves your PR.
  2. We don't merge PRs with failed tests.
    1. When tests fail, click on the Details link to learn more.
    2. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
    3. Tests may fail if you edit sensitive files. Ask to add the ignore-sensitive-files-pr label if the edits are necessary.
  3. We cannot merge PRs with conflicting files. These must be fixed.

Our policies make our code better.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🔭 Outside diff range comments (1)
INSTALLATION.md (1)

Line range hint 1-376: Add required label for protected file modification

This file is protected and requires the 'ignore-sensitive-files-pr' label to be modified. Please add this label to the PR.

🧰 Tools
🪛 LanguageTool

[duplication] ~28-~28: Possible typo: you repeated a word.
Context: ...](#running-talawa-admin) - Accessing Talawa-Admin - [Talawa-Admin Registration](#talawa-admin-registratio...

(ENGLISH_WORD_REPEAT_RULE)

🪛 Markdownlint (0.37.0)

36-36: Expected: 4; Actual: 6
Unordered list indentation

(MD007, ul-indent)


37-37: Expected: 4; Actual: 6
Unordered list indentation

(MD007, ul-indent)

🪛 GitHub Actions: PR Workflow

[error] Unauthorized file modification. This file is protected and requires the 'ignore-sensitive-files-pr' label to modify or delete.

🧹 Nitpick comments (5)
INSTALLATION.md (5)

35-37: Fix indentation in Table of Contents

The Git hooks subsections are incorrectly indented with 6 spaces instead of 4 spaces.

- [Husky for Git Hooks](#husky-for-git-hooks)
-       - [pre-commit hook](#pre-commit-hook)
-       - [post-merge hook](#post-merge-hook)
+ [Husky for Git Hooks](#husky-for-git-hooks)
+     - [pre-commit hook](#pre-commit-hook)
+     - [post-merge hook](#post-merge-hook)
🧰 Tools
🪛 Markdownlint (0.37.0)

36-36: Expected: 4; Actual: 6
Unordered list indentation

(MD007, ul-indent)


37-37: Expected: 4; Actual: 6
Unordered list indentation

(MD007, ul-indent)

🪛 GitHub Actions: PR Workflow

[error] Unauthorized file modification. This file is protected and requires the 'ignore-sensitive-files-pr' label to modify or delete.


170-179: Use environment variable for Docker port mapping

The Docker run command hardcodes port 4321, but it should use the PORT from .env file for consistency with the rest of the documentation.

- docker run -p 4321:4321 talawa-admin
+ docker run -p ${PORT}:${PORT} talawa-admin
🧰 Tools
🪛 GitHub Actions: PR Workflow

[error] Unauthorized file modification. This file is protected and requires the 'ignore-sensitive-files-pr' label to modify or delete.


199-199: Add language specification to code block

For consistency with other code blocks, specify the language.

- ```
+ ```bash
cp .env.example .env
🧰 Tools
🪛 Markdownlint (0.37.0)

199-199: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

🪛 GitHub Actions: PR Workflow

[error] Unauthorized file modification. This file is protected and requires the 'ignore-sensitive-files-pr' label to modify or delete.


199-199: Add missing environment variable to the table

The environment variables table is missing REACT_APP_USE_RECAPTCHA which is mentioned later in the document.

Add this row to the environment variables table:

 | REACT_APP_BACKEND_WEBSOCKET_URL | URL endpoint for websocket end point              |
+| REACT_APP_USE_RECAPTCHA         | Whether you want to use reCAPTCHA or not          |
 | REACT_APP_RECAPTCHA_SITE_KEY    | Site key for authentication using reCAPTCHA       |
🧰 Tools
🪛 Markdownlint (0.37.0)

199-199: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

🪛 GitHub Actions: PR Workflow

[error] Unauthorized file modification. This file is protected and requires the 'ignore-sensitive-files-pr' label to modify or delete.


362-364: Add language specification to git command blocks

For consistency with other code blocks, specify the language.

- ```
+ ```bash
git commit -m "commit message" --no-verify
- ```
+ ```bash
git pull --no-verify

Also applies to: 373-374

🧰 Tools
🪛 Markdownlint (0.37.0)

362-362: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

🪛 GitHub Actions: PR Workflow

[error] Unauthorized file modification. This file is protected and requires the 'ignore-sensitive-files-pr' label to modify or delete.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5fdeaf2 and 4f11c11.

📒 Files selected for processing (1)
  • INSTALLATION.md (4 hunks)
🧰 Additional context used
🪛 LanguageTool
INSTALLATION.md

[duplication] ~28-~28: Possible typo: you repeated a word.
Context: ...](#running-talawa-admin) - Accessing Talawa-Admin - [Talawa-Admin Registration](#talawa-admin-registratio...

(ENGLISH_WORD_REPEAT_RULE)


[uncategorized] ~197-~197: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...at runtime. It is not a part of the repo and you will have to create it. For a sampl...

(COMMA_COMPOUND_SENTENCE)

🪛 Markdownlint (0.37.0)
INSTALLATION.md

36-36: Expected: 4; Actual: 6
Unordered list indentation

(MD007, ul-indent)


37-37: Expected: 4; Actual: 6
Unordered list indentation

(MD007, ul-indent)


199-199: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


362-362: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)


372-372: null
Fenced code blocks should have a language specified

(MD040, fenced-code-language)

🪛 GitHub Actions: PR Workflow
INSTALLATION.md

[error] Unauthorized file modification. This file is protected and requires the 'ignore-sensitive-files-pr' label to modify or delete.

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyse Code With CodeQL (javascript)

@palisadoes
Copy link
Contributor

Closing. There is no issue assigned to this PR.

@palisadoes palisadoes closed this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants