Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typing-extensions dependency missing #172

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

alperenkose
Copy link
Collaborator

Description

Missing dependency in pyproject.toml causing panos_upgrade_assurance module not found error.

Motivation and Context

This is a critical issue which makes panos_upgrade_assurance fail to run.

Had to fix it to a specific version "4.6.3", otherwise it breaks pydoc-markdown which have conflicting dependencies. We need to take care of this with #171

Error: [Traceback (most recent call last):
   
   File "<string>", line 7, in <module>
   File "/usr/local/lib/python3.10/site-packages/panos_upgrade_assurance/firewall_proxy.py", line 3, in <module>
    from panos_upgrade_assurance.utils import interpret_yes_no
   File "/usr/local/lib/python3.10/site-packages/panos_upgrade_assurance/utils.py", line 5, in <module>
    from typing_extensions import TypeAlias
 ModuleNotFoundError: No module named 'typing_extensions'

How Has This Been Tested?

Tested manually with example scripts.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Had to fix typing-extensions version since higher versions are not
compatible with databind 4.5 which also breaks pydoc-markdown
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Collaborator

@horiagunica horiagunica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alperenkose alperenkose merged commit dcd88c6 into main Aug 20, 2024
8 checks passed
@alperenkose alperenkose deleted the typing-extensions-dependency-missing branch August 20, 2024 09:03
github-actions bot pushed a commit that referenced this pull request Aug 20, 2024
## [1.0.1](v1.0.0...v1.0.1) (2024-08-20)

### Bug Fixes

* typing-extensions dependency missing ([#172](#172)) ([dcd88c6](dcd88c6))
@horiagunica
Copy link
Collaborator

🎉 This PR is included in version 1.0.1 🎉

The release is available on PyPI and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants