87 make hdf datasets always be float64 unless they are pcap bits #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evalott100
force-pushed
the
87-make-hdf-datasets-always-be-float64-unless-they-are-pcap-bits
branch
from
83e47c5
to
fa3b730
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 97.08% 97.12% +0.04%
==========================================
Files 12 12
Lines 1200 1217 +17
==========================================
+ Hits 1165 1182 +17
Misses 35 35 ☔ View full report in Codecov by Sentry. |
|
@coretl Once this is merged I'll patch release since this fixes the numpy problems on main |
Thus it will use a `uint32` datatype.
coretl
reviewed
Jul 12, 2024
|
@coretl any takes on the 3.8 problem mentioned above? |
coretl
reviewed
Jul 17, 2024
coretl
approved these changes
Jul 18, 2024
evalott100
deleted the
87-make-hdf-datasets-always-be-float64-unless-they-are-pcap-bits
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #87
Also fixes the table packing error on main (probably due to the numpy update)
There are also places in tests where asyncio tasks aren't properly cleaned up (only shown with
export PYTHONASYNCIODEBUG=1, but we should handle this in a different issue.We may also want to think about dropping
python 3.8... The test failure there is from a docstring test, where numpy v2 (unavailable on 3.8) has a different output from numpy v1.24.