Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed TablePacking #64

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Removed TablePacking #64

merged 2 commits into from
Nov 2, 2023

Conversation

evalott100
Copy link
Contributor

@evalott100 evalott100 commented Oct 25, 2023 •
edited
Loading

After #15 we no longer used TablePacking, but instead imported words_to_table and table_to_words from pandablocks-client.

@evalott100 evalott100 self-assigned this Oct 25, 2023
@evalott100 evalott100 marked this pull request as draft October 25, 2023 07:29
@evalott100 evalott100 changed the title Reremoved TablePacking Removed TablePacking Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eba34d5) 86.29% compared to head (0dd1cb0) 89.61%.
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   86.29%   89.61%   +3.32%     
==========================================
  Files           7        7              
  Lines        1138     1088      -50     
  Branches      187      176      -11     
==========================================
- Hits          982      975       -7     
+ Misses        121       78      -43     
  Partials       35       35
Files Coverage Δ
src/pandablocks_ioc/_tables.py 93.83% <100.00%> (+15.29%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evalott100 evalott100 marked this pull request as ready for review October 25, 2023 08:08
AlexanderWells-diamond
AlexanderWells-diamond requested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@AlexanderWells-diamond AlexanderWells-diamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UnpackedArray definition near the top of this file should also be removed and replaced by the one from PandABlocks-client.

@evalott100
Reremoved TablePacking
cb62c89
@evalott100
Imported UnpackedArray instead of defining it
0dd1cb0 
Imported `UnpackedArray` from `pandablocks.utils` instead
of defining it again in pandablocks-ioc.
@evalott100
Copy link
Contributor Author

Code is failing because of the test fixed in #63

AlexanderWells-diamond
AlexanderWells-diamond approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@AlexanderWells-diamond AlexanderWells-diamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@evalott100 evalott100 merged commit cc0fb39 into PandABlocks:main Nov 2, 2023
10 checks passed
@evalott100 evalott100 deleted the remove_table_packing_utils branch November 2, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderWells-diamond AlexanderWells-diamond AlexanderWells-diamond approved these changes

Assignees

@evalott100 evalott100

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evalott100 @AlexanderWells-diamond