-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pi#2778 open report editor #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gretacodes
commented
Feb 6, 2025
•
edited
Loading
edited
- all the files in docs/ directory are here temporarily until a proper solution is designed to deploy the documentation to Github Pages - this should ideally be a part of the CI. for the time being, the content from docs/ directory is automatically published to github pages. The documentation available is currently coming from 2778_open_report_editor branch but will be amended once this is merged in to main. The code existing in docs/ directory doesn't need to be reviewed as this is what gets generated by jsdoc lib.
- minified library build will be available in the Releases section github. This will be published once this branch is merged in into main
- documentation link - https://panintelligence.github.io/pi-embed-actions/
- using jsdoc and clean-jsdoc-theme to generate documentation
- using esbuild to make a minified js build
- mocha and chai used for js unit testing
…ligence/pi-embed-actions into 2778_open_report_editor
gretacodes
commented
Feb 6, 2025
…change comments in code
neilmusgrove
reviewed
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great, I've added a few comments mainly on the documentation side where I think we could improve clarity a little.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.