Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add exact choice shapeless support #11546

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Machine-Maker
Copy link
Member

No description provided.

@Machine-Maker Machine-Maker marked this pull request as ready for review November 1, 2024 02:18
@Machine-Maker Machine-Maker requested a review from a team as a code owner November 1, 2024 02:18
@Machine-Maker
Copy link
Member Author

Tested with exact choice shapeless recipes. As always, there are a few caveats with how these work in relation to the client. If your exact choice recipe doesn't include ingredients with damaged items, enchanted items, or "custom_name" items (NOT item_name), then they should work 100%. If you have ingredients that are damaged, enchanted, or have "custom_name" (displayName) NOT "item_name" (itemName), then the recipe book will show them as uncraftable and multiple clicks on the item won't keep adding 1 "recipe" to the grid, you get one click (or shift click).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Awaiting review
Development

Successfully merging this pull request may close these issues.

1 participant