Fix cursor item being lost when PlayerDropItemEvent is cancelled and …

[FlorianMichael]

…the player inventory is full

See this video for a tutorial on how to reproduce this issue: https://youtu.be/xonJe2S7jQ8. Note that you also need to have the PlayerDropItemEvent cancelled in the test plugin.

[B1ue-Bandit]

Listen to InventoryClickEvent instead and cancel it if the click type is DROP

[FlorianMichael]

What? The event is cancellable for a reason and this is clearly a wrong implementation, why would this be a proper fix?

[B1ue-Bandit]

No no, you're right. Your fix would be a welcome change, I was just suggesting a workaround for the time being but I probably should've said that

[FlorianMichael]

Oh I see, thanks for the suggestion, I have it already fixed in our paper fork and decided to upstream the change :) Blue Bandit ***@***.***> schrieb am Fr., 25. Apr. 2025, 05:22:

…

*B1ue-Bandit* left a comment (PaperMC/Paper#12475) <#12475 (comment)> No no, you're right. Your fix would be a welcome change, I was just suggesting a workaround for the time being but I probably should've said that — Reply to this email directly, view it on GitHub <#12475 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOKAS7ZC5RUGCWKQD5LJYW323GTAZAVCNFSM6AAAAAB32PN2VWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRZGI4DQMJQGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[lynxplay]

This only resolves the issue when dropping the entire stack on cursor.
Dropping a single stack (single item from a stack of e.g. 64) from the cursor does still loose items (specifically, the items left in the cursor being overridden by the dropped stack)

[Clexus]

A question, what if player quit the game with full inventory and items on cursor? will them drop or just disappear

[FlorianMichael]

@Clexus The item will be lost, I also noticed something similar happening when using the bundle item.

[aerulion]

For reference, there has already been a discussion about this issue (#7726 and #7727). Although I still like the idea of having the overflow consumer described in the linked pull request.