Properly update hidden effects #13173
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warriorrrr
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13172
When an effect of the same type is added to an entity, we construct a new MobEffectInstance-instance and update that to see if any property of the existing effect can be overriden by the new effect. This works well, except for that the update method also has one extra side effect, namely updating the hidden effect, which doesn't count as overriding anything.
This PR adds some extra logic to check if the new effect should be added as a hidden effect if it isn't already being overriden, so that no effect gets lost.
Tested by drinking a long regeneration potion and a short regeneration 2 potion, regardless of which potion was drank first the longer effect always returned after the short one ended.