feat: Add new overloads for Pathfinder

[Toffikk]

Fixes #13191

[Warriorrrr]

Not really a fan of deprecating the existing method, wouldn't that require everyone to cast to Entity to not get the deprecation warning? The existing method could also become a default and call the new one.

[Toffikk]

Not really a fan of deprecating the existing method, wouldn't that require everyone to cast to Entity to not get the deprecation warning? The existing method could also become a default and call the new one.

I get the point but i deprecated it because LivingEntity is extending Entity so we shouldn't keep an overload that's basically going to do the same thing as the other one but more limited, the best solution would be to remove the old one but that would cause all plugins to need to be recompiled. The devs can choose to either suppress that warning in some way or just wait until the old one gets removed and update their dependency on paper-api and everything will work fine, no matter if they start casting to Entity now or leave their code as it is

[Toffikk]

We could perhaps add an @apiNote with a notice that their plugins might require a recompile on the next version and a link to the new overloads

[masmc05]

so we shouldn't keep an overload that's basically going to do the same thing as the other one but more limited

I don't see why not, it's not like that default LivingEntity method would ever require maintenance when it's just redirecting to the Entity method

We could perhaps add an @APinote with a notice that their plugins might require a recompile on the next version and a link to the new overloads

Sounds extremely awful

[Toffikk]

so we shouldn't keep an overload that's basically going to do the same thing as the other one but more limited

I don't see why not, it's not like that default LivingEntity method would ever require maintenance when it's just redirecting to the Entity method

I'll change that then to redirect to the new one

[Toffikk]

done, now the LivingEntity overloads just redirect to the Entity ones

[Doc94]

also i found another javadoc issues not caused by this PR but maybe can be good fix like L185

[Lulu13022002]

That's wrong as per oracle convention, also i would rather not do cleanup of this nature until checkstyle is in, can you revert all your changes apart from the two overload changes.

[Toffikk]

@Lulu13022002 everything should be addressed now👍
I left the repeated to removal tho