Minecraft 1.21.5

[RealBauHD]

No description provided.

[pkt77]

Bug: Players kicked for chat packets. This is due to the new byte checksum at the end of LastSeenMessages

[RealBauHD]

Before we can actually merge this, we need something to respect the component changes e. g. KyoriPowered/adventure#1168

[electronicboy]

I fixed some issues connecting to the latest RC in this, however, there still appears to be something going sideways for me, and, I need to get back to being productive

[RealBauHD]

What kind of problems have you encountered?

[electronicboy]

First I was getting kicked because of the argument registry being incorrect,

Now;

---- Minecraft Network Protocol Error Report ----
// Don't worry, I'll be fine

Time: 2025-03-25 12:53:56
Description: Packet handling error

java.lang.IllegalStateException: Registry minecraft:advancement not found
	at ji$a.i(SourceFile:116)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at ji$a.e(SourceFile:116)
	at fp.<init>(SourceFile:38)
	at fp$a$a.a(SourceFile:113)
	at fp$a$a.b(SourceFile:104)
	at acx$a.a(SourceFile:170)
	at acx$d.a(SourceFile:336)
	at acx$d.a(SourceFile:348)
	at acx$d.a(SourceFile:348)
	at acx$d.a(SourceFile:348)
	at acx$d.a(SourceFile:348)
	at acx$d.a(SourceFile:348)
	at acx.a(SourceFile:266)
	at glp.a(SourceFile:1557)
	at acx.a(SourceFile:262)
	at acx.a(SourceFile:39)
	at zr.a(SourceFile:27)
	at btq.d(SourceFile:164)
	at btv.d(SourceFile:23)
	at btq.B(SourceFile:138)
	at btq.bA(SourceFile:123)
	at fqq.c(SourceFile:1308)
	at fqq.f(SourceFile:936)
	at net.minecraft.client.main.Main.main(SourceFile:265)
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:105)
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129)
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:70)

I'm imagining that there is still some issue with arg parsing and it's tripping up over on consuming something it shouldn't, I'd probably want to double check the one I added, but, I'm not sure

[RealBauHD]

Should be fixed now, the error was caused by the class being registered twice, resulting in an incorrect class to id mapping.

[electronicboy]

hnnnnng; I really want to find some means of cleaning this system up; debugging when stuff goes sideways is often such a pain in the arse

[PedroMPagani]

Maybe it would be nice to remove that blockage on the write packet for the chat queue

[kennytv]

Ready for review I decided:tm: the rest can be handled later