Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move assets.json file into mache directory #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Leguan16
Copy link

@Leguan16 Leguan16 commented Nov 2, 2024

A small change but this moves the runClientSetupAssets.json file into the .gradle/mache directory instead of the root .gradle directory.

@jpenilla
Copy link
Member

jpenilla commented Nov 3, 2024

This looks like you are actually moving it from build to build/mache? Is there a reason this is necessary?

@Leguan16
Copy link
Author

Leguan16 commented Nov 3, 2024

I just figured moving mache stuff into the mache directory makes sense.
Right now it would also not be deleted by the clearMacheCache task because it's not in the mache directory.

@Leguan16

This comment was marked as outdated.

@Leguan16
Copy link
Author

Leguan16 commented Nov 4, 2024

Ok what i wrote there did not make any sense. Sorry for that I don't know what happened there lol.

What exactly are you implying with your message? Are you saying this is unnecessary and if so, why? Are you suggesting moving it into the ./gradle/mache directory?

My initial point still stands with "Im doing it for consistency and that all mache generated files are in mache directories".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants