Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doors! Ports Tau Ceti's Door Sprites #22530

Closed
wants to merge 1 commit into from

Conversation

OctusGit
Copy link
Contributor

@OctusGit OctusGit commented Sep 21, 2023

What Does This PR Do

Ports TauCetiStation/TauCetiClassic#4536
Updates a majority of our doors to use TauCeti door sprites. (the same place we got our walls from)

Why It's Good For The Game

They look better, having the doors that were designed to work with our walls is visually much better than the old ugly doors we currently have.

Images of changes

dreamseeker_Nm09p0Ve6e
dreamseeker_RPqWMCMTL1
dreamseeker_UIRpTumQuJ

Testing

yep

Changelog

🆑 TungstenOctopus Octus
imageadd: Replaces a majority of current door sprites with newer ported door sprites.
/:cl:

@Henri215 Henri215 added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Sep 21, 2023
@Henri215
Copy link
Contributor

"imageadd:" instead of "tweak:"

@OctusGit OctusGit closed this Sep 21, 2023
@OctusGit OctusGit reopened this Sep 21, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Sprites This PR modifies the game sprites labels Sep 21, 2023
@matttheficus
Copy link
Contributor

The Engineering doors look the Sec doors.

Also soul removal.

Also I don't think these match much of any of our sprites.

Also I personally think theyre kinda ugly.

@Mitchs98
Copy link
Contributor

Fully agree with Matt.

They look incredibly out of place with the theme the server has. They look more militaristic than science-station-y to me. And personally our current doors actually kind of match better than these doors?

@McRamon
Copy link
Contributor

McRamon commented Sep 22, 2023

Fully agree with Matt.

They look incredibly out of place with the theme the server has. They look more militaristic than science-station-y to me. And personally our current doors actually kind of match better than these doors?

A little curious - what are the features of science-stationy and militaristic airlocks? How do i differenciate them in future?

@AyIong
Copy link
Contributor

AyIong commented Sep 22, 2023

You can partially use this PR, hopefully it will make the job easier.
Plus a certain amount of stuff has been drawn
Specifically overlays and light masks

image

@Mitchs98
Copy link
Contributor

Fully agree with Matt.
They look incredibly out of place with the theme the server has. They look more militaristic than science-station-y to me. And personally our current doors actually kind of match better than these doors?

A little curious - what are the features of science-stationy and militaristic airlocks? How do i differenciate them in future?

I'm not really sure how to describe what would seem to match more. I do know though that these remind me quite a bit of TGMC. Can't really think of a good way to describe anything better though, sorry.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Sep 24, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Oct 7, 2023
@Henri215
Copy link
Contributor

Henri215 commented Oct 7, 2023

What is left to be done so it can leave draft state?

@OctusGit
Copy link
Contributor Author

OctusGit commented Oct 8, 2023

What is left to be done so it can leave draft state?

Oh just some fixes to doors, and a look at the PR by Aylong, ive been just busy, was gonna do it sometime this week

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting review This PR is awaiting review from the review team labels Oct 12, 2023
@S34NW S34NW added the Stale This PR has been left inactive and requires an update. label Oct 31, 2023
Copy link
Member

@S34NW S34NW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes in 3 weeks, PR marked as stale. It will be closed in 7 days if no substantial changes are made.

@OctusGit OctusGit closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting approval This PR is waiting for approval internally Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Sprites This PR modifies the game sprites Stale This PR has been left inactive and requires an update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants