-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LORE] Extensive Modsuit Lore Drop #27119
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: CRUNCH <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: CRUNCH <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: CRUNCH <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Henri215 <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Henri215 <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Henri215 <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Henri215 <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Henri215 <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Henri215 <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Henri215 <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Henri215 <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes. Good work on the rest.
Co-authored-by: Git-GoR <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Git-GoR <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Git-GoR <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Henri215 <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Henri215 <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
…dise into modsuit-lore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit of a readability review, meaning a lot of nitpicks. Feel free to dismiss changes you don't feel are especially necessary.
Co-authored-by: Luc <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Luc <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Luc <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Luc <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Luc <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Luc <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reposting the feedback given in Discord:
Cybersun Industries being the manufacturers of the standard and engi/atmos MODsuits is something that should be reconsidered. Not because they are competitors, but because as it stands right now Cybersun has clear links to the Syndicate. Not only are all the items they make illegal, their lore description mentions it being an open secret. It would not make much sense for NT to keep utilizing equipment from someone who directly funds terror attacks against their stations and convoys. Their involvement would have to be made much more secretive for this to be maintained.
An easier solution would be to change the company to another existing one, of which the Xion Manufacturing Group seems to be a decent fit. They are a Skrell-based company, which means that Solar-Central Compact relations are strengthened - and would directly boost NT's PR. If this approach were to be taken, a reference to Cybersun being the old NT supplier could be added to the description, something along the lines of their relations being cut after some internal investigation or something.
Co-authored-by: CRUNCH <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: CRUNCH <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, pending final approval.
Made one small optional suggestion.
Co-authored-by: Burzah <[email protected]> Signed-off-by: PopeDaveThe3th <[email protected]>
What Does This PR Do
Adds new descriptions and extended descriptions to all player-usable modsuits, except the clown one.
Also renames modsuits with unique nicknames related to their function.
Why It's Good For The Game
Lore is good.
Lore that isn't stolen from TG is even better.
Testing
Declaration
I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.
Changelog
🆑
tweak: Changed the descriptions and extended descriptions of almost all modsuits. Updated suits were also given unique names relevant to their occupation.
/:cl: