Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LORE] Extensive Modsuit Lore Drop #27119

Open
wants to merge 42 commits into
base: master
Choose a base branch
from

Conversation

PopeDaveThe3th
Copy link
Contributor

@PopeDaveThe3th PopeDaveThe3th commented Oct 15, 2024

What Does This PR Do

Adds new descriptions and extended descriptions to all player-usable modsuits, except the clown one.

Also renames modsuits with unique nicknames related to their function.

Why It's Good For The Game

Lore is good.

Lore that isn't stolen from TG is even better.

Testing

  • Loaded in
  • Observed many modsuits
  • Lore is updated

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.


Changelog

🆑
tweak: Changed the descriptions and extended descriptions of almost all modsuits. Updated suits were also given unique names relevant to their occupation.
/:cl:

code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
PopeDaveThe3th and others added 4 commits October 15, 2024 19:18
Co-authored-by: CRUNCH <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: CRUNCH <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: CRUNCH <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Oct 16, 2024
@Henri215 Henri215 added Tweak This PR tweaks something ingame Lore This PR changes or adds new lore to the game. Requires Wiki Update Useful for Wiki Contributers to search for things that need updating labels Oct 16, 2024
code/modules/mod/mod_theme.dm Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Show resolved Hide resolved
PopeDaveThe3th and others added 8 commits October 16, 2024 07:11
Co-authored-by: Henri215 <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Henri215 <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Henri215 <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Henri215 <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Henri215 <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Henri215 <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Henri215 <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Henri215 <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
Copy link
Contributor

@Git-GoR Git-GoR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes. Good work on the rest.

code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
PopeDaveThe3th and others added 8 commits October 16, 2024 08:10
Co-authored-by: Git-GoR <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Git-GoR <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Git-GoR <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Henri215 <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Henri215 <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
Copy link
Contributor

@lewcc lewcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit of a readability review, meaning a lot of nitpicks. Feel free to dismiss changes you don't feel are especially necessary.

code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Show resolved Hide resolved
Co-authored-by: Luc <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
PopeDaveThe3th and others added 7 commits October 16, 2024 15:03
Co-authored-by: Luc <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Luc <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Luc <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Luc <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
Co-authored-by: Luc <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Oct 21, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Oct 26, 2024
Copy link
Contributor

@Git-GoR Git-GoR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reposting the feedback given in Discord:

Cybersun Industries being the manufacturers of the standard and engi/atmos MODsuits is something that should be reconsidered. Not because they are competitors, but because as it stands right now Cybersun has clear links to the Syndicate. Not only are all the items they make illegal, their lore description mentions it being an open secret. It would not make much sense for NT to keep utilizing equipment from someone who directly funds terror attacks against their stations and convoys. Their involvement would have to be made much more secretive for this to be maintained.

An easier solution would be to change the company to another existing one, of which the Xion Manufacturing Group seems to be a decent fit. They are a Skrell-based company, which means that Solar-Central Compact relations are strengthened - and would directly boost NT's PR. If this approach were to be taken, a reference to Cybersun being the old NT supplier could be added to the description, something along the lines of their relations being cut after some internal investigation or something.

code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
Co-authored-by: CRUNCH <[email protected]>
Signed-off-by: PopeDaveThe3th <[email protected]>
Copy link
Contributor

@Burzah Burzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, pending final approval.
Made one small optional suggestion.

code/modules/mod/mod_theme.dm Outdated Show resolved Hide resolved
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Lore This PR changes or adds new lore to the game. Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Tweak This PR tweaks something ingame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants