-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Device resprite #28302
base: master
Are you sure you want to change the base?
Device resprite #28302
Conversation
I'm just one player, so I dunno if my opinion would apply to the entire playerbase here, but the big prong-shape ontop of the pinpointers look kind of weird and make the pinpointers feel unusually large? Not sure on a solution or if this idea even holds up when looked at in-game. |
I would be inclined to agree. Rest of the sprite looks great but the comically large antenna is a tad distracting. |
Don't ever feel like you can't put constructive feedback on a PR. It is something that we want to see when it comes to changing things. It gives more for the author, voting teams, and reviewers to consider. |
I think the new t-ray scanner sprites look too much like TG multitool sprites which might confuse people coming from those servers. Is there a reason you changed the color to yellow? |
Never knew our current pinpointers had antennas on them, but can't say I am a fan of making them bigger (at least not the forked style). Also isn't the color scheme of contractors black with a yellow accent? With the colors here, it looks like an engineering tool, maybe try replacing the yellow on the top surface with a brighter black, and replace the orange horizontal lines on top with yellow lines? Looks good otherwise. Also, for the syndicate teleporter, are those sprites are meant to indicate charge or an animation? |
You can checj iconduff, its 4 states for for different charge levels, each is animated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks to me like syndi-tele-0
is broken.
I think my issue with these pinpointers is that so much screen real estate is lost. The pinpointers we have now are ugly, but there's a lot to be said for the plain red on plain white, where I think these arrows are quite a bit more visually obscure, especially looking at something like pinonmedium_crew
The rest is fantastic although I think there's something to be said for keeping the T-ray scanner blue.
What Does This PR Do
Resprites pinpointers, t-ray scanner and syndicate teleporter
Bobus! - declaration of war device now has unique sprite
Why It's Good For The Game
rbmk core exploded, graphite is on the ground
Images of changes
Bonus sprite:
![image](https://private-user-images.githubusercontent.com/31545294/411286404-c3af5d8d-67c8-4037-b423-caff97b837b8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNDAwODAsIm5iZiI6MTczOTIzOTc4MCwicGF0aCI6Ii8zMTU0NTI5NC80MTEyODY0MDQtYzNhZjVkOGQtNjdjOC00MDM3LWI0MjMtY2FmZjk3YjgzN2I4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDAyMDk0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNkYjQzYzc0ODNiYTVjMjdhNmQ0ZTA5MGQ2M2QxYWMyMGNlMGIwNTI1ZmUzMjFjNzdhZDc3MjMxNTA2YTFlYjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.BgBNKAGQ9hpwDaJ1-NHqBL2IVkg_99e2Dh_uYXbSqbk)
Testing
not this time
Declaration
Changelog
🆑
imageadd: New sprites for t-ray scanner, syndicate teleporter, pinpointers and declaration of war device
/:cl: