Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device resprite #28302

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Device resprite #28302

wants to merge 3 commits into from

Conversation

McRamon
Copy link
Contributor

@McRamon McRamon commented Feb 9, 2025

What Does This PR Do

Resprites pinpointers, t-ray scanner and syndicate teleporter

Bobus! - declaration of war device now has unique sprite

Why It's Good For The Game

rbmk core exploded, graphite is on the ground

Images of changes

image

Bonus sprite:
image

Testing

not this time


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
imageadd: New sprites for t-ray scanner, syndicate teleporter, pinpointers and declaration of war device
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Sprites This PR modifies the game sprites labels Feb 9, 2025
@TravisAngeI
Copy link

TravisAngeI commented Feb 9, 2025

I'm just one player, so I dunno if my opinion would apply to the entire playerbase here, but the big prong-shape ontop of the pinpointers look kind of weird and make the pinpointers feel unusually large? Not sure on a solution or if this idea even holds up when looked at in-game.

@PopeDaveThe3th
Copy link
Contributor

I'm just one player, so I dunno if my opinion would apply to the entire playerbase here, but the big prong-shape ontop of the pinpointers look kind of weird and make the pinpointers feel unusually large? Not sure on a solution or if this idea even holds up when looked at in-game.

I would be inclined to agree. Rest of the sprite looks great but the comically large antenna is a tad distracting.

@Burzah
Copy link
Member

Burzah commented Feb 9, 2025

I'm just one player, so I dunno if my opinion would apply to the entire playerbase here, but the big prong-shape ontop of the pinpointers look kind of weird and make the pinpointers feel unusually large? Not sure on a solution or if this idea even holds up when looked at in-game.

Don't ever feel like you can't put constructive feedback on a PR. It is something that we want to see when it comes to changing things. It gives more for the author, voting teams, and reviewers to consider.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Feb 9, 2025
@autocephalophagy
Copy link

I think the new t-ray scanner sprites look too much like TG multitool sprites which might confuse people coming from those servers. Is there a reason you changed the color to yellow?

@Christer2222
Copy link

Never knew our current pinpointers had antennas on them, but can't say I am a fan of making them bigger (at least not the forked style). Also isn't the color scheme of contractors black with a yellow accent? With the colors here, it looks like an engineering tool, maybe try replacing the yellow on the top surface with a brighter black, and replace the orange horizontal lines on top with yellow lines? Looks good otherwise.

Also, for the syndicate teleporter, are those sprites are meant to indicate charge or an animation?

@McRamon
Copy link
Contributor Author

McRamon commented Feb 10, 2025

opinion

You can checj iconduff, its 4 states for for different charge levels, each is animated

Copy link
Contributor

@pwbokie pwbokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me like syndi-tele-0 is broken.

I think my issue with these pinpointers is that so much screen real estate is lost. The pinpointers we have now are ugly, but there's a lot to be said for the plain red on plain white, where I think these arrows are quite a bit more visually obscure, especially looking at something like pinonmedium_crew

The rest is fantastic although I think there's something to be said for keeping the T-ray scanner blue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Sprites This PR modifies the game sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants