Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow decompilation of shrapnel and cardboard tubes #28306

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

Arthri
Copy link
Contributor

@Arthri Arthri commented Feb 9, 2025

What Does This PR Do

  • Allows the matter decompiler (of engineering cyborgs and maintenance drones) to decompile shrapnel and empty cardboard tubes

Why It's Good For The Game

Less trash on station

Testing

  1. created trash
  2. decompiled trash
  3. floor clean

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑 cdui
tweak: Engineering Cyborgs' and Maintenance Drones' Matter Decompiler to allow decompilation of shrapnel and empty cardboard boxes
/:cl:

@ColKev1
Copy link

ColKev1 commented Feb 9, 2025

Does this include all gun magazine types? Some magazines are difficult to get more of (stetchkin, donksoft mags) and most are refillable (laser projector mags, WT mags).

@Arthri
Copy link
Contributor Author

Arthri commented Feb 9, 2025

Yes. Although now that you mention it, I should limit or remove decompilation of magazines. I was under the false assumption that all magazines were easy to obtain

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Feb 9, 2025
Copy link
Contributor

@1080pCat 1080pCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drones should NOT be able to decon magazines, even if they're empty. As it could lead to un/intentional drone interactions that could change peoples runs
The other stuff looks fine thoguh

@Fordoxia
Copy link
Contributor

Fordoxia commented Feb 9, 2025

Drones should NOT be able to decon magazines, even if they're empty. As it could lead to un/intentional drone interactions that could change peoples runs The other stuff looks fine thoguh

Seconded. Empty magazines are actually very useful, they just need to have fresh bullets stuffed into them. Not trash.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Feb 9, 2025
@Arthri Arthri changed the title Allow decompilation of shrapnel, cardboard tubes, ammo boxes, and magazines Allow decompilation of shrapnel and cardboard tubes Feb 10, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Feb 11, 2025
Copy link
Member

@chuga-git chuga-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Feb 12, 2025
@silverplatedelta silverplatedelta added the Tweak This PR tweaks something ingame label Feb 12, 2025
@lewcc lewcc added this pull request to the merge queue Feb 12, 2025
Merged via the queue into ParadiseSS13:master with commit b472a86 Feb 12, 2025
19 checks passed
@Arthri Arthri deleted the decompile-matter branch February 13, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Tweak This PR tweaks something ingame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants