Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a runtime in PDA gas scanner code #28310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

silverplatedelta
Copy link
Contributor

What Does This PR Do

Fixes a null value runtime in PDA atmos scanner code

Why It's Good For The Game

Runtime bad

Testing

Compiles, now gives a readout when scanning empty pipes


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
fix: PDA atmos scanners no longer runtime when scanning empty devices.
/:cl:

@silverplatedelta silverplatedelta added Fix This PR will fix an issue in the game Runtime This issue is a runtime error labels Feb 9, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Feb 9, 2025
Comment on lines +784 to +793
total_moles += air?.total_moles()
volume += air?.return_volume()
heat_capacity += air?.heat_capacity()
thermal_energy += air?.thermal_energy()
oxygen += air?.oxygen()
nitrogen += air?.nitrogen()
toxins += air?.toxins()
carbon_dioxide += air?.carbon_dioxide()
sleeping_agent += air?.sleeping_agent()
agent_b += air?.agent_b()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
total_moles += air?.total_moles()
volume += air?.return_volume()
heat_capacity += air?.heat_capacity()
thermal_energy += air?.thermal_energy()
oxygen += air?.oxygen()
nitrogen += air?.nitrogen()
toxins += air?.toxins()
carbon_dioxide += air?.carbon_dioxide()
sleeping_agent += air?.sleeping_agent()
agent_b += air?.agent_b()
if(!air)
continue
total_moles += air.total_moles()
volume += air.return_volume()
heat_capacity += air.heat_capacity()
thermal_energy += air.thermal_energy()
oxygen += air.oxygen()
nitrogen += air.nitrogen()
toxins += air.toxins()
carbon_dioxide += air.carbon_dioxide()
sleeping_agent += air.sleeping_agent()
agent_b += air.agent_b()

If air is non-null, all of these procs are valid calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Fix This PR will fix an issue in the game Runtime This issue is a runtime error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants