-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes a runtime in PDA gas scanner code #28310
Open
silverplatedelta
wants to merge
1
commit into
ParadiseSS13:master
Choose a base branch
from
silverplatedelta:ScannerFix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuga-git
reviewed
Feb 12, 2025
Comment on lines
+784
to
+793
total_moles += air?.total_moles() | ||
volume += air?.return_volume() | ||
heat_capacity += air?.heat_capacity() | ||
thermal_energy += air?.thermal_energy() | ||
oxygen += air?.oxygen() | ||
nitrogen += air?.nitrogen() | ||
toxins += air?.toxins() | ||
carbon_dioxide += air?.carbon_dioxide() | ||
sleeping_agent += air?.sleeping_agent() | ||
agent_b += air?.agent_b() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
total_moles += air?.total_moles() | |
volume += air?.return_volume() | |
heat_capacity += air?.heat_capacity() | |
thermal_energy += air?.thermal_energy() | |
oxygen += air?.oxygen() | |
nitrogen += air?.nitrogen() | |
toxins += air?.toxins() | |
carbon_dioxide += air?.carbon_dioxide() | |
sleeping_agent += air?.sleeping_agent() | |
agent_b += air?.agent_b() | |
if(!air) | |
continue | |
total_moles += air.total_moles() | |
volume += air.return_volume() | |
heat_capacity += air.heat_capacity() | |
thermal_energy += air.thermal_energy() | |
oxygen += air.oxygen() | |
nitrogen += air.nitrogen() | |
toxins += air.toxins() | |
carbon_dioxide += air.carbon_dioxide() | |
sleeping_agent += air.sleeping_agent() | |
agent_b += air.agent_b() |
If air
is non-null, all of these procs are valid calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
-Status: Awaiting review
This PR is awaiting review from the review team
Fix
This PR will fix an issue in the game
Runtime
This issue is a runtime error
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Fixes a null value runtime in PDA atmos scanner code
Why It's Good For The Game
Runtime bad
Testing
Compiles, now gives a readout when scanning empty pipes
Declaration
Changelog
🆑
fix: PDA atmos scanners no longer runtime when scanning empty devices.
/:cl: