Remove invalid UTF8 check from Repr::from_utf8_unchecked
#379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the following code from
Repr::from_utf8_unchecked
:compact_str/compact_str/src/repr/mod.rs
Lines 126 to 137 in d479863
In my opinion, this code should be removed for 2 reasons:
from_utf8_unchecked
thatbuf
is the bytes of a valid UTF8 string. This check penalizes users who follow the safety contract (which everyone should), in order to support users who don't (and therefore have opted in to UB).buf
ends with the first byte of a multi-byte Unicode character, for example calling.as_str().chars().collect::<Vec<char>>()
on the resultingCompactString
will cause an out of bounds read.