Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCH: Fix potential fatal with 'enqueue_settings_assets' strict parameter #2610

Merged
merged 2 commits into from
Jul 5, 2024
Merged

PCH: Fix potential fatal with 'enqueue_settings_assets' strict parameter #2610

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d19f4ce
Fix issue with possible fatal due to the strict type of the `enqueue_…
vaurdan Jul 5, 2024
d9465fe
Merge branch 'develop' into fix/fatal-with-strict-type
vaurdan Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 25 additions & 23 deletions src/UI/class-settings-page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,31 +158,33 @@ public function run(): void {
/**
* Enqueues all needed scripts and styles for Parse.ly plugin settings page.
*
* @param string $hook_suffix The current page being loaded.
* @param string|null $hook_suffix The current page being loaded.
*/
public function enqueue_settings_assets( string $hook_suffix ): void {
if ( 'settings_page_parsely' === $hook_suffix ) {
add_filter( 'media_library_months_with_files', '__return_empty_array' );
wp_enqueue_media();

$admin_settings_asset = get_asset_info( 'build/admin-settings.asset.php' );
$built_assets_url = plugin_dir_url( PARSELY_FILE ) . '/build/';

wp_enqueue_script(
'parsely-admin-settings',
$built_assets_url . 'admin-settings.js',
$admin_settings_asset['dependencies'],
$admin_settings_asset['version'],
true
);

wp_enqueue_style(
'parsely-admin-settings',
$built_assets_url . 'admin-settings.css',
$admin_settings_asset['dependencies'],
$admin_settings_asset['version']
);
public function enqueue_settings_assets( ?string $hook_suffix ): void {
if ( ! is_string( $hook_suffix ) || 'settings_page_parsely' !== $hook_suffix ) {
return;
}

add_filter( 'media_library_months_with_files', '__return_empty_array' );
wp_enqueue_media();

$admin_settings_asset = get_asset_info( 'build/admin-settings.asset.php' );
$built_assets_url = plugin_dir_url( PARSELY_FILE ) . '/build/';

wp_enqueue_script(
'parsely-admin-settings',
$built_assets_url . 'admin-settings.js',
$admin_settings_asset['dependencies'],
$admin_settings_asset['version'],
true
);

wp_enqueue_style(
'parsely-admin-settings',
$built_assets_url . 'admin-settings.css',
$admin_settings_asset['dependencies'],
$admin_settings_asset['version']
);
}

/**
Expand Down