Move MPI behavior from HTEX to MPIExecutor #3582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benclifford
requested changes
Aug 14, 2024
yadudoc
force-pushed
the
reorg_mpiexecutor
branch
4 times, most recently
from
65abe9b
to
3628427
Compare
benclifford
reviewed
Aug 16, 2024
benclifford
requested changes
Aug 16, 2024
| provider=SlurmProvider(launcher=launcher), | ||
| ) | ||
| ]) | ||
|
|
||
|
|
||
| @pytest.mark.local | ||
| def test_correct_launcher_with_mpi_mode(): | ||
| def test_bad_mpi_launcher(): | ||
| """ValueError if an unsupported mpi_launcher is specified""" |
There was a problem hiding this comment.
this test looks for a type error not a value error?
There was a problem hiding this comment.
it's meant to be a test for a value error though, right?
yadudoc
force-pushed
the
reorg_mpiexecutor
branch
from
ff92e88
to
6aef5dd
Compare
benclifford
reviewed
Aug 16, 2024
test-requirements.txt
Outdated
| @@ -25,4 +25,3 @@ Sphinx==4.5.0 | |||
| twine | |||
| wheel | |||
| isort | |||
|
|
|||
* Adding `validate_resource_specification` method to HTEX and overriding that with MPI specific validation in MPIEX * HTEX will no longer accept mpi_resource_specification even with `enable_mpi_mode=True` * `enable_mpi_mode` and `mpi_launcher` are no longer supported in HTEX. `mpi_launcher` is now set only via MPIEX * MPI specific checks are now in MPIEX instead of HTEX
yadudoc
force-pushed
the
reorg_mpiexecutor
branch
from
6aef5dd
to
9a6be96
Compare
benclifford
approved these changes
Aug 16, 2024
This was referenced Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the following MPI related functionality and options from HTEX to MPIExecutor:
enable_mpi_modeandmpi_launcheris now removed from HTEXmpi_launcherin now in MPIExecutorvalidate_resource_specificationmethod is added to HTEX that currently asserts that no resource_specification is passed to it, since HTEX does not support any such optionsvalidate_resource_specificationto check for a valid MPI resource specificationThese changes should make it easier to have executor specific resource validation.
Changed Behaviour
enable_mpi_modeandmpi_launcherare no longer supported.Type of change
I'm marking this as maintenance since the docs have moved on to only advertize MPI functionality through MPIExecutor.