Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationaizing Resource Specification errors acorss executors. #3627

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Harichandra-Prasath
Copy link
Contributor

Description

There are three places where the executors raise the errors regarding resource specification.

  1. when passing the resource_specification parameter to the htex, it raises the mpi_prefix_composer InvalidResourceSpecification from validate_resource_spec method. https://github.com/Parsl/parsl/blob/master/parsl/executors/high_throughput/executor.py#L342

  2. ThreadPoolExecutor also raises the UnsupportedFeatureError when passing resource specification to it, https://github.com/Parsl/parsl/blob/master/parsl/executors/threads.py#L54

  3. WorkQueueExecutor raises two errors similar to this but as a Base ExecutorError, one when there is invalid resource_specification ; https://github.com/Parsl/parsl/blob/master/parsl/executors/workqueue/executor.py#L418 and another one when the autolabel is false and resource_specification is not right, https://github.com/Parsl/parsl/blob/master/parsl/executors/workqueue/executor.py#L429

This PR rationalize these errors by creating a InvalidResourceSpecificationError in executors.error and using it across the executors. Moreover InvalidResourceSpecification and MissingResourceSpecification is removed from mpi_prefix_composer and places where the above two used were replaced with InvalidResourceSpecificationError.

Changed Behaviour

From this PR, All executors will raise InvalidResourceSpecificationError for errors regarding resource_spec.

Fixes

Fixes #3589

Type of change

  • Bug fix
  • Code maintenance/cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rationalize invalid resource specification errors
1 participant