Support send-only endpoint configuration #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jpalac
commented
Sep 5, 2023
•
jpalac
commented
- Rebase of [Spike] Support send-only endpoints #618
- Fixes Using SendOnly throws a KeyNotFoundException with Main as a key #617
jpalac
changed the title
mikeminutillo
approved these changes
Sep 6, 2023
|
|
||
| class SendOnlyReceiver : IMessageReceiver | ||
| { | ||
| static readonly InvalidOperationException SendOnlyEndpointException = new($"This endpoint cannot process messages because it is configured in send-only mode. Remove the '{nameof(EndpointConfiguration)}.{nameof(EndpointConfiguration.SendOnly)}' configuration or do not call '{nameof(IFunctionEndpoint)}.{nameof(IFunctionEndpoint.ProcessAtomic)}/{nameof(IFunctionEndpoint.ProcessNonAtomic)}'"); |
There was a problem hiding this comment.
I'm not sure if we can safely have a singleton exception instance and throw it multiple times, possibly concurrently. What happens if it is thrown at one site, then thrown from a different site before the first throw is caught? What does the stack trace look like? I think it would be better to recreate this every time.
Perhaps we want to change this to make it closer to Particular/NServiceBus.AzureFunctions.Worker.ServiceBus#377
mikeminutillo
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.