Update RabbitMQ transport connection string options #4755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonsmits
reviewed
Jan 31, 2025
| using global::RabbitMQ.Client; | ||
|
|
||
| class ConnectionFactory | ||
| { | ||
| readonly string endpointName; | ||
| readonly global::RabbitMQ.Client.ConnectionFactory connectionFactory; | ||
| readonly object lockObject = new object(); | ||
| readonly SemaphoreSlim semaphoreSlim = new(1, 1); |
There was a problem hiding this comment.
Don't forget to properly dispose the semaphore
There was a problem hiding this comment.
Thanks for the heads up. I'll take another look at this. I thought that the semaphoreSlim.Release() did the dispose, but maybe putting this in a using statement would be better so that the semaphoreSlim is always disposed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.