-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for .NET 9 #6947
base: master
Are you sure you want to change the base?
Update for .NET 9 #6947
Conversation
1af7ccb
to
73a36ba
Compare
The error occurs when building samples/hosting/aspire/Core_9/AspireDemo.AppHost/AspireDemo.AppHost.csproj it seems that there is a dependency on aspire which needs to be installed:
I downloaded it and ran it in my local environment and got the same error. In local env, the solution is to just run the suggested command and it runs just fine. I am not 100% sure how we ought to resolve this in the CI though. I think we probably need to add the command We could add a logic test of some sort to only run the command for those solutions which need it, but unless it leads to unacceptably slow performance, I think that it would be best practice to just run it all the time for every solution. So, that this doesnt accidentally catch some future dev by surprise when they add a sample that has a build dependency not normally anticipated by the script. |
533cb43
to
e9dea92
Compare
No description provided.