We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug Conversion from String to byte[] changes the original generated salt in Argon2
String
byte[]
To Reproduce
Hash hash = Password.hash(test.plainTextPassword).addRandomSalt().withArgon2(); assertTrue(Password.check(test.plainTextPassword, hash)); // fails
in particular what is generated by HashBuilder#addRandomSalt() is different from Hash#salt
HashBuilder#addRandomSalt()
Hash#salt
Expected behavior HashBuilder#addRandomSalt() == Hash#salt
Environment: 1.7.3+
The text was updated successfully, but these errors were encountered:
#143: fix salt generation for Argon2
ded2c06
Successfully merging a pull request may close this issue.
Describe the bug
Conversion from
String
tobyte[]
changes the original generated salt in Argon2To Reproduce
in particular what is generated by
HashBuilder#addRandomSalt()
is different fromHash#salt
Expected behavior
HashBuilder#addRandomSalt()
==Hash#salt
Environment:
1.7.3+
The text was updated successfully, but these errors were encountered: