fix addRandomSalt

[mr-ken]

BUGFIX:
Changing the default character set to UTF-8 in v1.7.3 seems to have broken HashBuilder.addRandomSalt() and HashBuilder.addRandomSalt(int length). Using addSalt(String salt) with a properly encoded String fixes that.

[firaja]

BUGFIX: Changing the default character set to UTF-8 in v1.7.3 seems to have broken HashBuilder.addRandomSalt() and HashBuilder.addRandomSalt(int length). Using addSalt(String salt) with a properly encoded String fixes that.

Hi @mr-ken

can you provide an example of the issue?
Thank you very much!

[mr-ken]

BUGFIX: Changing the default character set to UTF-8 in v1.7.3 seems to have broken HashBuilder.addRandomSalt() and HashBuilder.addRandomSalt(int length). Using addSalt(String salt) with a properly encoded String fixes that.

Hi @mr-ken

can you provide an example of the issue? Thank you very much!

If you run the provided tests without the changes to HashBuilder, they will fail. I assume they should pass?

[firaja]

@mr-ken thank you for the test and yes they should pass.

In your PR you convert the salt into a String and then back to bytes[]. This rung me a bell and in fact the problem was about the encoding of the salt in the Hash object.

So I changed this line in Argon2Function (#internalHash)

Hash result = new Hash(this, encodeHash(hash, salt), hash, Utils.fromBytesToString(salt));

with

Hash result = new Hash(this, encodeHash(hash, salt), hash, salt);

and your tests are working fine!
This is the commit ded2c06 and the related issue #143

I also deprecated Hash#Hash(HashingFunction, String, byte[], String) because working with a mixture of strings and bytes create inconsistencies; and in 1.7.x Argon2 gave problems with that, so that's why I reworked the way data is encoded, but I totally missed your use case in my tests 😞

So even this PR cannot be merged I really want to thank you!
But your tests will be included anyway in 1.8.1.

PS: let me know if this implementation is working fine in your project (branch master).

[mr-ken]

Do you have an estimate when you'll release v1.8.1?

[firaja]

Do you have an estimate when you'll release v1.8.1?

I think within this week.

[firaja]

@mr-ken 1.8.1 released, thank you for your collaboration!