SAF-782 android notifications #1284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The copy changes have been green lighted! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
juancruzgs
reviewed
Jul 22, 2020
Comment on lines
+10
to
+11
| <string name="background_service_notification_channel_name">Background location service</string> | ||
| <string name="android_permission_notification_channel_name">Permission notifications</string> |
There was a problem hiding this comment.
@JacobJaffe Should we translate these strings?
juancruzgs
reviewed
Jul 22, 2020
Comment on lines
+297
to
+298
| "location_enabled_message": "Your location is securely stored every five minutes on this device.", | ||
| "location_enabled_title": "Background location enabled", |
There was a problem hiding this comment.
@JacobJaffe And should we also translate these?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 of the 2 PRs as proposed solution described in this issue #1276
Should be merged together with
Path-Check/background-geolocation-android#3