Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key mapping fixes #58

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Wires77
Copy link
Member

@Wires77 Wires77 commented Apr 1, 2024

Fixes PathOfBuildingCommunity/PathOfBuilding#7478

This also removes what appears to be some vestigial code leftover from the SG 2.0 work, and corrects the regression initially fixed by #27

Function should be renamed most likely, but was copied from glfw/glfw#1502 (comment)

ImGui shared a workaround function that is copied here to remap
from scancodes back to key values, as most users will use them
@zao
Copy link
Contributor

zao commented Apr 10, 2024

Deployed on test machine, tested with English (US), French and German layouts on a physically US keyboard.
Shortcut keys are now correct, but as I tested I noticed several odd things that occur in release 2.42.0 as well and isn't this PR's fault:

  • In Notes, Ctrl-Z and Ctrl-Y undo and redo twice on every press.
  • In Tree with a fresh skill tree, the very first skill node allocation doesn't undo at all.

Copy link
Contributor

@zao zao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CTRL+Z doesn't undo and closes the build on azerty keyboard
2 participants