Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental Android support #635

Closed
wants to merge 6 commits into from
Closed

Conversation

ZaneYork
Copy link
Contributor

@ZaneYork ZaneYork commented Apr 9, 2019

No description provided.

@Pathoschild Pathoschild self-requested a review April 9, 2019 17:54
@Pathoschild Pathoschild added the enhancement This is a general improvement that can be addressed with specific development changes. label Apr 9, 2019
@Pathoschild
Copy link
Owner

Thanks! This is an interesting approach, but I prefer not changing the game executable or recreating each mod. Instead of patching the game to call SMAPI, would this approach (similar to other platforms) work on Android?

  1. When the user launches the game, it runs the SMAPI executable instead of the game executable;
  2. SMAPI loads the game, adds mods, and launches the game as a subprocess.

This has the benefit of being easier to install (don't need to change the game executable itself), and in theory other mods could be added as-is without reimplementing each one.

@ZaneYork
Copy link
Contributor Author

Good idea.But this strategy needs a Android Application to grab Dlls from Stardew Valley and delegate it.However,if user does not have root access, the Application should extract Contents from apk file.
I will improve this branch later, so that mod developer don't have to transportation mods.

@Pathoschild Pathoschild changed the title Android Experimental Android support Apr 10, 2019
yangzhi added 4 commits April 10, 2019 23:10
…mpatible Check.

Some of the mod without transportation may works now
LookupAnything and UI Info Suite MOD
@alightbullb
Copy link

Any idea how soon this could be playable? Thanks so much for the hard work btw!

@Pathoschild
Copy link
Owner

@alightbullb You can try it already. It's still experimental and unofficial though, so expect bugs, issues, and most mods outright not working yet.

@Pathoschild
Copy link
Owner

@ZaneYork Thanks for all your work! Unfortunately this pull request can't be merged for two reasons:

  • It removes support for players on Linux/Mac/Windows and removes most of the internal code. Ideally the main repository should support all platforms, using conditional compilation where necessary to account for crossplatform differences. At a minimum, the main repository should support Linux/Mac/Windows since those are the main and original platforms.
  • It includes the source code for several mods without complying with their code licenses. Some of those mods have incompatible licenses or are fully copyrighted, so redistributing their code without permission is a copyright violation.

As such I'll close this pull request. Feel free to submit a new pull request when those are addressed, or maintain a SMAPI fork for Android! You can discuss progress in the tracking ticket (#632), which I'll also update with a link to your repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is a general improvement that can be addressed with specific development changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants