Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure script runs through a terminal #937

Merged
merged 1 commit into from
Jul 7, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/SMAPI.Installer/assets/install on Linux.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,22 @@
#!/usr/bin/env bash

function open_in_terminal { # Checks for a few different terminal emulators to launch the installer through
if which konsole 2&>1 >/dev/null; then # KDE Konsole
konsole -e $1
elif which alacritty 2&>1 >/dev/null; then # Alacritty
alacritty -e $1
elif which gnome-terminal 2&>1 >/dev/null; then # GNOME Terminal
gnome-terminal -- $1
elif which xterm 2&>1 >/dev/null; then # Xterm
xterm -e $1
else # Use notify-send to send a message that none of these terminals were found installed and instruct the user to manually invoke this script through a terminal
notify-send --app-name="SMAPI Installer" --urgency=critical "Failed to find a terminal to open installer with. Please use a terminal program to open the 'install on Linux.sh' script"
fi
}

cd "`dirname "$0"`"
internal/linux/SMAPI.Installer
if [ -t 0 ]; then # Uses `test` to check if the File Descriptor for Standard Input is valid -- STDIN should be valid if script was invoked through a terminal, and invalid if the file was invoked through a file explorer that didn't wrap it in a terminal emulator
./internal/linux/SMAPI.Installer
else
open_in_terminal ./internal/linux/SMAPI.Installer
fi