Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin: Flag entity-related issues #1287

Merged
merged 5 commits into from
Jul 26, 2024
Merged

Admin: Flag entity-related issues #1287

merged 5 commits into from
Jul 26, 2024

Conversation

jvwong
Copy link
Member

@jvwong jvwong commented Jul 24, 2024 •
edited
Loading

Here I augment the admin/model to flag common entity-level issues:

  • ungrounded (non-complex) entities
  • mixed organisms (could signal orthologue issues)

Question: For convenience, I added an entity normalized method, but I can't recall what the difference is between associated and completed?

Refs #1286, part 'c'

@jvwong jvwong requested a review from maxkfranz July 24, 2024 14:55
jvwong
jvwong commented Jul 24, 2024
View reviewed changes
src/model/element/entity.js
normalized(){
// normalized := has a name and is associated
const name = this.syncher.get('name');
return name && this.associated() && this.completed();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what 'completed' was supposed to indicate?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

associated true (entity/node only) => grounded

completed (any element / node / edge) => the user has finished specifying the element

E.g. an interaction doesn't have a grounding but it can still be completed by specifying it as phosphorylation.

@jvwong
Copy link
Member Author

jvwong commented Jul 24, 2024

Admin page examples for (top) unnormalized entity (blocks public status) (bottom) mixed organisms (warning)
Screenshot 2024-07-24 at 11 21 47 AM

maxkfranz
maxkfranz approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@maxkfranz maxkfranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Suggestion for future: A filter at the top for these flagged, problematic documents would be nice so you don't have to hunt for them.

I suppose a submitted/not-public would be the same, but it's not as clear.

351774702-e181f6f8-d5ae-41ab-94c7-bf666c3cc6b8

@jvwong
Copy link
Member Author

jvwong commented Jul 26, 2024 •
edited
Loading

Looks great.

Suggestion for future: A filter at the top for these flagged, problematic documents would be nice so you don't have to hunt for them.

Good point, there are some blocked (submitted) contributions that I never reviewed, missed.

Add this to a few other admin features required, based on things I'm doing manually:

@jvwong jvwong merged commit a474cb6 into unstable Jul 26, 2024
@jvwong jvwong mentioned this pull request Jul 26, 2024
Open
@jvwong jvwong deleted the iss1286_admin-flag-ungrounded branch July 26, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxkfranz maxkfranz maxkfranz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvwong @maxkfranz