Expanding hints scope #1294
Merged
Expanding hints scope #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now it accepts all hint types from PubTator rather than just organisms. e.g. genes, cell lines, diseases, chemicals - Added tests for the new hint types. - Updated the hint model to accept all hint types.
jvwong
reviewed
Aug 8, 2024
jvwong
requested changes
Aug 8, 2024
- hint model constructor modified to use setters to initialize properties and enforce validation - pubtator test updated to use new getter methods to access hint properties rather than direct access to properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference to issue #1148 :