Handle unavailable installation #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Remove capability 'available_installation_current' if unavailable + only pull available current if available
…n updateChargeMode()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some occasions the charger is part of a larger grid installation that is controlled by another account. In for instance a Condominium.
Therefore the given installation id on the charger is not available. As a consequence the available current is not available. And the action card "Set available current to" will also fail.
I added a check on pollSlowValues() if the installation is available. If not, removes the capability "Current limit" (available_installation_current). But adds it again if available.
Also added check if this capability exists on the device, on all the methods that uses the /installation/ endpoint.
Found this to be the best solution