Skip to content

pat-inject code optimizations #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 12, 2025
Merged

pat-inject code optimizations #1222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1b19844
fix(core dom): Do not break querySelectorAllAndMe, if passed element …
thet Jan 12, 2025
3369d3a
pat-inject: Improve code for updating the history object.
thet Jan 3, 2024
5c3c1aa
pat-inject: Minor code optimization.
thet Jan 4, 2024
fa07469
pat-inject: Minor code optimization: Consistently use nodeName over t…
thet Jan 12, 2025
d5f69c2
pat-inject: Minor code optimization: Rework most forEach to for loops.
thet Jan 12, 2025
9a55aa3
pat-inject: Code modernization: Remove dependency on jquery-ext.
thet Jan 12, 2025
cdc346a
pat-inject: Minor code optimization.
thet Jan 12, 2025
b0f94fb
maint(pat inject): Modernize some parts of pat inject.
thet May 16, 2023
8a3af53
maint(pat-inject): Use create_uuid for generating the temporary autol…
thet Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const toNodeArray = (nodes) => {
* @returns {Array} - The DOM nodes found.
*/
const querySelectorAllAndMe = (el, selector) => {
if (!el) {
if (!el || !el.querySelectorAll) {
return [];
}

Expand Down
9 changes: 9 additions & 0 deletions src/core/dom.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,15 @@ describe("core.dom tests", () => {

done();
});

it("return empty list, if the element is not a real element.", (done) => {
const res = dom.querySelectorAllAndMe("text", ".selector");
expect(Array.isArray(res)).toBe(true);
expect(res.length).toBe(0);

done();
});

});

describe("wrap tests", () => {
Expand Down
Loading
Loading