This repository has been archived by the owner on Oct 7, 2021. It is now read-only.
Manage digits in target temperature for Climate Devices #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added list of allowed temperature step to use in HA - fixed set_temperature to manage digits and choose update mode
matitalatina
approved these changes
Dec 14, 2020
Closed
21 tasks
|
@PaulAnnekov please, can you have a look at it? We can't proceed further otherwise. |
|
@matitalatina @ollo69 thank you. Already in version 0.0.10. |
|
Thanks @PaulAnnekov, I will create HA PR this w.e. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contain 2 fixes for climate device:
add list of allowed temperature steps to use in HA and fix the
set_temperaturemethod to manage digits: this will allow in HA to define different temperature steps and will manage steps with decimals. This PR replace PR climate: Add halves when divider is at least 2 #54 and PR Add support for decimal values on set temperature #59add a parameter to
set_temperaturemethod to choose update mode (fix for issue Siterwell GS361A-H04 #51)I will create required PR in HA to bump new version and apply required changes if this PR will be approved.