Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added salting to the password #60

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

TaillandyV
Copy link

Added hashing directly to enhance the security, hashed keys are stored in "password" and the salt is added. This will proceed as such:

The salt given to this user + password entered by the user are hashed using sha-256 then compared to the hashed stored in the database for this user. If it is the same, connect the user if not don't connect the user.

This change allows for enhanced security; the passwords are not stored (Let it be on the app, on a database when shiny is launched remotely or if the source code is found.) , only the hashed result and the salt can be found.

Check for more information on salting : https://auth0.com/blog/adding-salt-to-hashing-a-better-way-to-store-passwords/

@TaillandyV
Copy link
Author

Hi,

This is a version that I have just modified for my own use, so it is not up for deployment but I though the idea could lead to a better version of shinyauthr if the user could choose.

Thanks for shinyauthr !

@PaulC91
Copy link
Owner

PaulC91 commented Jul 12, 2022

Hi, there is already password hashing options provided via the sodium package. This is designed to protect against brute force attacks whereas algorithms such as sha-256 are not. See https://github.com/PaulC91/shinyauthr#hashing-passwords-with-sodium and #13 for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants