Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arduino r4 support - added #96

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mjs513
Copy link

@mjs513 mjs513 commented Jul 18, 2023

@PaulStoffregen - @KurtE

When trying to update the library for the new R4 boards (Minima and WiFi) ran into an issue where attaching the interrupt did not work. Thanks to @KurtE found that the issue was with doing it from the constructor which took a while to track down. But he came up with a simple solution that maintains backward compatibility. More can found here: https://forum.arduino.cc/t/encoder-library-attachinterrupt-not-working-from-within-library/1149007

Basically creates a begin method that can be used but when you begin:

Encoder myEnc ;

void setup() { myEnc.begin(2,3); }

This can be used for any board. This method still works though:

Encoder myEnc(2, 3) ;

without using begin in the setup.

I did try it with a Teensy 4.1, Uno, Mega, Nano 33 IoT, and adafruits metro Express m0 board.

@mjs513
Copy link
Author

mjs513 commented Jul 21, 2023

Just a quick update - verified changes work on a ESP32-C3 and a ESP32-S2

@mjs513 mjs513 changed the title Arduino r4 Arduino r4 support - added Jul 21, 2023
melvinm1 added a commit to melvinm1/ConfigurableFirmata that referenced this pull request Jul 26, 2023
@pandel
Copy link

pandel commented Mar 11, 2024

@mjs513 I tried your fork today with a R4 WIFI, but sadly, it does not work. I even used a basic example to make sure, it is not an error I introduced in my code. Both variants, with interrupts or not don't give any results.

The encoder itself works fine with the original library and a UNO R3.

Do you have an idea how I could start debugging whats happening?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants